[redland-dev] missing release_handle in rdf_storage_postgresql ?

Maxence Guesdon Maxence.Guesdon at inria.fr
Wed Mar 7 05:15:39 EST 2012


Hello,

In function librdf_storage_postgresql_find_statements_with_options of
rdf_storage_postgresql.c, the function gets a new db handle with
  librdf_storage_postgresql_get_handle
but in case of success, it is not released.

In fact, it is, but later, when the returned stream is freed, thanks to the
pointer on librdf_storage_postgresql_find_statements_in_context_finished
passed as finalization function to librdf_new_stream.

Wouldn't it be better to release the db handle as soon as possible ?
For example, by adding
  librdf_storage_postgresql_release_handle(sos->storage, sos->handle);
just before the final
   return stream;
?

Regards,

Maxence



More information about the redland-dev mailing list